feat(config): sync hook and mfa config to remote #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11772202395Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sweatybridge
force-pushed
the
sync-hook
branch
from
08040c7
to
6fe7019
Compare
sweatybridge
changed the title
avallete
approved these changes
Nov 8, 2024
pkg/config/auth_test.go
Outdated
Comment on lines
61
to
70
| assert.Contains(t, string(diff), `[hook.mfa_verification_attempt]`) | ||
| assert.Contains(t, string(diff), `-enabled = true`) | ||
| assert.Contains(t, string(diff), `+enabled = false`) | ||
| assert.Contains(t, string(diff), `uri = ""`) | ||
| assert.Contains(t, string(diff), `secrets = ""`) | ||
|
|
||
| assert.Contains(t, string(diff), `[hook.custom_access_token]`) | ||
| assert.Contains(t, string(diff), `-enabled = false`) | ||
| assert.Contains(t, string(diff), `+enabled = true`) | ||
| assert.Contains(t, string(diff), `uri = ""`) |
There was a problem hiding this comment.
question
Is there an equivalent to toMatchInlineSnapshot in Go ? That could maybe be useful instead of repeating the contains for every line as it would also test for the lines order.
There was a problem hiding this comment.
Not that I'm aware of. But I'm interested as well.
A low hanging fruit is to write the expected diff output to a file under testdata for comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
part 4 of #2814
What is the new behavior?
Sync
hook,mfa, andsessionsconfig to remote.Additional context
Add any other context or screenshots.